Update BlissMotor - #1651
Merged
Merged
Conversation
Phantominumm
commented
Aug 18, 2026
Phantominumm
commented
Contributor
- Explicitly register the actuator via bliss_proxy.hardware.register() before fetching it
- Remove the 'tape' velocity/jog special-case in get/set value, always use position/move()
- Store the move() callback and add wait_ready() to block until BLISS confirms completion
Phantominumm
force-pushed
the
pr/bliss-motor
branch
from
August 18, 2026 07:50
b8c2159 to
d893afa
Compare
marcus-oscarsson
force-pushed
the
pr/bliss-motor
branch
from
September 10, 2026 07:16
d893afa to
ac1d888
Compare
beteva
reviewed
Sep 10, 2026
Comment on lines
+192
to
+199
| try: | ||
| pos = self.motor_obj.position | ||
| except Exception: | ||
| return self._nominal_value if self._nominal_value is not None else None | ||
| if pos is None: | ||
| # motor_obj.position can be None during init or if REST call returns null | ||
| return self._nominal_value if self._nominal_value is not None else 0.0 | ||
| return pos |
Member
There was a problem hiding this comment.
Not sure about this logic. To be tested
beteva
reviewed
Sep 10, 2026
Comment on lines
+206
to
+211
|
|
||
| _yaml_low = self.get_property("low_limit") | ||
| _yaml_high = self.get_property("high_limit") | ||
| if _yaml_low is not None and _yaml_high is not None: | ||
| self._nominal_limits = (float(_yaml_low), float(_yaml_high)) | ||
| else: |
Member
There was a problem hiding this comment.
Do we want this here? Why not in the init?
beteva
reviewed
Sep 10, 2026
| "Motor object not found for actuator '%s'" % (self.actuator_name,) | ||
| ) | ||
|
|
||
| self.update_state(HardwareObjectState.BUSY) |
Member
There was a problem hiding this comment.
Not quite sure why we need this.
beteva
reviewed
Sep 10, 2026
Comment on lines
+263
to
+269
| def wait_ready(self, timeout: float | None = None): | ||
| if self._motor_callback is None: | ||
| return | ||
| with Timeout(timeout, RuntimeError("Timeout waiting for motor to be ready")): | ||
| self._motor_callback.get(monitor_interval=0.2) | ||
| self.update_state() | ||
| self.update_value() |
Member
There was a problem hiding this comment.
This was only a temporary fix, because the _on_property_changed and _on_online _changed were not executed. Check if still the case and eventually remove it.
beteva
approved these changes
Sep 10, 2026
beteva
left a comment
beteva
left a comment
Member
There was a problem hiding this comment.
Approve for now, but needs some more testing
marcus-oscarsson
force-pushed
the
pr/bliss-motor
branch
from
September 10, 2026 14:56
1082741 to
f3105f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.